Codinion

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Enhanced Syntax Highlighting
  • Priority Very Low
  • Reported Version 1.0.0.3247 Beta
  • Due in Version Undecided
  • Votes
  • Private
Attached to Project: Codinion
Opened by wmj - 10.02.2016
Last edited by Martin Topfstedt - 11.02.2016

FS#39 - Theme File Corruption & Inconsistency Issues Continued

Hello,

I've just upgraded to the last beta. The theme file corruption issue and inconsistency issues were not yet fixed.

Corruption issue:
The new theme file has gotten somehow messed up with two encodings, apparently UTF-8 and UTF-32.
The theme file serialization part shall have some problem.
And there's no need to save the theme file in UTF-32. UTF-8 will do.

Inconsistency issue:
The new beta saves the theme file in XML format.
But the Settings.xml file still references to the old binary format.
Thus the new theme won't get loaded after theme changes.

Closed by  Martin Topfstedt
11.02.2016 19:55
Reason for closing:  Fixed
Admin
Martin Topfstedt commented on 10.02.2016 13:43

I saved the theme file in UTF-32 because of the font name, i have no idea what the string will look like on a chinese system and UTF-8 wouldn't work for such characters.

That the settings file still has the binary file is strange.

Could you save your old theme/settings files and try with complete new ones?

Admin
Martin Topfstedt commented on 10.02.2016 18:28

I changed the xml encoding back to UTF-8. Please delete all your settings so far and try to start fresh.

wmj commented on 11.02.2016 08:27

UTF-8 could perfectly encode all Unicode characters, including Chinese, Japanese, Korean, and so on.

I suspected that the theme saving part did not truncate the rest part of the file. Firstly the theme file was N bytes, and afterward re-configuring, the theme file became M bytes, where M < N, therefore the XML theme file corruption occurred.

I renamed the old Settings.xml and CurrentTheme.xml file and restarted VS.
It seemed that the new beta was working fine.
But you may still check out the theme saving part in your code.

Admin
Martin Topfstedt commented on 11.02.2016 08:32

I actually have the Truncate flag if the file already exists but i will do more test with different file sizes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing